Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
buildPortsToEndpointsMap should use flattened value type #81378
What type of PR is this?
What this PR does / why we need it:
We always flatten the value before using it.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
One idea is to create a utility class under pkg/proxy/ for this func (and isValidEndpoint).
Let me know what you think.
After moving TestValidateWorks and TestBuildPortsToEndpointsMap to pkg/proxy/util/utils_test.go , I got the following:
I think the cycle comes from :
where ServicePortName is in proxy
I will keep TestBuildPortsToEndpointsMap in roundrobin_test
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing