Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admission e2e tests for untested stable operations #81381

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@jpbetz
Copy link
Contributor

commented Aug 13, 2019

Fixes #80767

Adds e2e tests for:

  • update and patch of {Validating,Mutating}WebhookConfiguration, then ensuring changes are effective
  • delete and deletecollection (filtered by label) of {Validating,Mutating}WebhookConfiguration, then ensuring removal is effective

/sig-apimachinery
/sig-testing
/cc @liggitt @roycaihw @caesarxuchao @sttts

None

@k8s-ci-robot k8s-ci-robot requested review from caesarxuchao and liggitt Aug 13, 2019

@k8s-ci-robot k8s-ci-robot requested review from roycaihw and sttts Aug 13, 2019

@jpbetz jpbetz force-pushed the jpbetz:admission-e2e-operations branch 2 times, most recently from f5c10a0 to 6ac24d9 Aug 13, 2019

@jpbetz jpbetz force-pushed the jpbetz:admission-e2e-operations branch 2 times, most recently from fa80da6 to dfe782c Aug 14, 2019

test/e2e/apimachinery/webhook.go Outdated Show resolved Hide resolved
test/e2e/apimachinery/webhook.go Outdated Show resolved Hide resolved

@jpbetz jpbetz force-pushed the jpbetz:admission-e2e-operations branch from dfe782c to 3121773 Aug 14, 2019

@jpbetz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added this to Required for GA, in progress in Admission Webhooks Aug 14, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

flake #81238
/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

/kind feature
/priority important-soon

@k8s-ci-robot k8s-ci-robot merged commit 93e9abe into kubernetes:master Aug 14, 2019

23 checks passed

cla/linuxfoundation jpbetz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 14, 2019

@hh hh referenced this pull request Aug 17, 2019
2 of 3 tasks complete

@liggitt liggitt moved this from Required for GA, in progress to Complete in Admission Webhooks Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.