Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go 1.12.8 #81390

Merged
merged 3 commits into from Aug 14, 2019

Conversation

@cblecker
Copy link
Member

commented Aug 13, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Update to go 1.12.8

Which issue(s) this PR fixes:
ref #79912

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to use go 1.12.8

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

/priority critical-urgent
/sig release

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

Still to be done:

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

/assign

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

/assign @javier-b-perez
Would you mind building and pushing the image, Javier?

Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 13, 2019
@BenTheElder

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

I built / pushed an image, the CL is pending

@javier-b-perez

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

/lgtm

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 14, 2019
@BenTheElder

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

/test pull-kubernetes-verify

@cblecker cblecker force-pushed the cblecker:go-1.12.8 branch from 3cdf52f to 12dbfcb Aug 14, 2019
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Aug 14, 2019
@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

/test pull-kubernetes-bazel-test

The port name previously didn't matter on these tests, but is now
actively being checked in go1.12.8 and higher.

golang/go@3226f2d
@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

Pushed up a new commit to fix a test failure:

Tests under go1.12.7:

$ docker run --rm -v ${PWD}:/go/src/k8s.io/kubernetes -w /go/src/k8s.io/kubernetes golang:1.12.7 go test -v ./vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/... -run '(TestWithInvalidCaCertPath|TestInvalidCaCert)'
=== RUN   TestWithInvalidCaCertPath
--- PASS: TestWithInvalidCaCertPath (0.00s)
=== RUN   TestInvalidCaCert
--- PASS: TestInvalidCaCert (0.00s)
PASS
ok      k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib    0.027s
?       k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/diskmanagers       [no test files]
?       k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/fixtures   [no test files]

Tests under go1.12.8:

docker run --rm -v ${PWD}:/go/src/k8s.io/kubernetes -w /go/src/k8s.io/kubernetes golang:1.12.8 go test -v ./vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/... -run '(TestWithInvalidCaCertPath|TestInvalidCaCert)'
=== RUN   TestWithInvalidCaCertPath
E0814 04:43:25.865720    1179 connection.go:179] Failed to parse URL: <nil>. err: parse https://should-not-matter:should-not-matter: invalid port ":should-not-matter" after host
--- FAIL: TestWithInvalidCaCertPath (0.00s)
    connection_test.go:168: Expected an os.PathError, got: 'parse https://should-not-matter:should-not-matter: invalid port ":should-not-matter" after host' (&url.Error{Op:"parse", URL:"https://should-not-matter:should-not-matter", Err:(*errors.errorString)(0xc00003f8d0)})
=== RUN   TestInvalidCaCert
E0814 04:43:25.866151    1179 connection.go:179] Failed to parse URL: <nil>. err: parse https://should-not-matter:should-not-matter: invalid port ":should-not-matter" after host
--- FAIL: TestInvalidCaCert (0.00s)
    connection_test.go:182: Expected invalid certificate error, got 'parse https://should-not-matter:should-not-matter: invalid port ":should-not-matter" after host'
FAIL
FAIL    k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib    0.024s
?       k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/diskmanagers       [no test files]
?       k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/fixtures   [no test files]

Tests under go1.12.8 after fix:

$ docker run --rm -v ${PWD}:/go/src/k8s.io/kubernetes -w /go/src/k8s.io/kubernetes golang:1.12.8 go test -v ./vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/... -run '(TestWithInvalidCaCertPath|TestInvalidCaCert)'
=== RUN   TestWithInvalidCaCertPath
--- PASS: TestWithInvalidCaCertPath (0.00s)
=== RUN   TestInvalidCaCert
--- PASS: TestInvalidCaCert (0.00s)
PASS
ok      k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib    0.026s
?       k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/diskmanagers       [no test files]
?       k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/fixtures   [no test files]
@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

/test pull-kubernetes-integration

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

/retest

@@ -159,7 +159,7 @@ func TestWithValidThumbprint(t *testing.T) {
func TestWithInvalidCaCertPath(t *testing.T) {
connection := &vclib.VSphereConnection{
Hostname: "should-not-matter",
Port: "should-not-matter",

This comment has been minimized.

Copy link
@imkin

imkin Aug 14, 2019

Contributor

This could have been a fixture too may be. But its "doesn't matter" so may be we can live with this.

@imkin

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

/lgtm

@imkin

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, imkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -16,7 +16,7 @@

import boilerplate
import unittest
import StringIO
from io import StringIO

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Aug 14, 2019

Member

seems unrelated? how did the go bump switch this to python3?

This comment has been minimized.

Copy link
@cblecker

cblecker Aug 14, 2019

Author Member

Bazel was failing this test locally on my side when I bumped things. May be my setup?

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Aug 14, 2019

Member

ah. I thought we had it configured to force python2 /shrug
as long as it passes in CI, seems good to me

@k8s-ci-robot k8s-ci-robot merged commit 3526a61 into kubernetes:master Aug 14, 2019
23 checks passed
23 checks passed
cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 14, 2019
@cblecker cblecker deleted the cblecker:go-1.12.8 branch Aug 15, 2019
imkin added a commit to imkin/kubernetes that referenced this pull request Aug 15, 2019
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2019
#79966-#81390-#81489-upstream-release-1.14

Update release-1.14 to go 1.12.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.