Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/delete load balancer backendPoodID in VMSS. #81411

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@nilo19
Copy link
Member

commented Aug 14, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

Add/delete load balancer backendPoodID in VMSS.

Which issue(s) this PR fixes:

Fixes #80365

Does this PR introduce a user-facing change?:

Fix VMSS LoadBalancer backend pools so that the network won't be broken when instances are upgraded to latest model
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Hi @nilo19. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nilo19

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

/sig azure

@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

/ok-to-test

@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

/area provider/azure
/priority important-soon

@nilo19 nilo19 force-pushed the nilo19:t-qini-fix_80365 branch from 22d084d to f86e0e7 Aug 19, 2019
@nilo19 nilo19 force-pushed the nilo19:t-qini-fix_80365 branch 2 times, most recently from 872d9db to 491af23 Aug 19, 2019
@nilo19

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2019

/test pull-kubernetes-e2e-gce-100-performance

@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@nilo19 nilo19 force-pushed the nilo19:t-qini-fix_80365 branch from 491af23 to 86dd2a0 Aug 19, 2019
@nilo19 nilo19 force-pushed the nilo19:t-qini-fix_80365 branch from 86dd2a0 to b20256d Aug 19, 2019
@feiskyer feiskyer added this to In progress in Provider Azure via automation Aug 19, 2019
@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 11eaf43 into kubernetes:master Aug 19, 2019
23 checks passed
23 checks passed
cla/linuxfoundation nilo19 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Provider Azure automation moved this from In progress to Done Aug 19, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 19, 2019
@nilo19 nilo19 referenced this pull request Aug 19, 2019
6 of 6 tasks complete
@feiskyer feiskyer moved this from Done to KEPs in Provider Azure Aug 20, 2019
@feiskyer feiskyer moved this from KEPs to Done in Provider Azure Aug 20, 2019
k8s-ci-robot added a commit that referenced this pull request Aug 23, 2019
…-upstream-release-1.14

Automated cherry pick of #81411: Add/delete load balancer backendPoodID in VMSS.
k8s-ci-robot added a commit that referenced this pull request Aug 23, 2019
…-upstream-release-1.15

Automated cherry pick of #81411: Add/delete load balancer backendPoodID in VMSS.
@Cryptophobia

This comment has been minimized.

Copy link

commented Sep 29, 2019

Sorry above is a mistake. This change was all related to Azure but #82923 is the issue we're facing.

@nilo19 nilo19 deleted the nilo19:t-qini-fix_80365 branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.