-
Notifications
You must be signed in to change notification settings - Fork 41k
Promote Node Zone/Region Topology Labels to GA #81431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b699efc
to
f11ea8b
Compare
f11ea8b
to
ddc4337
Compare
4919796
to
437ce94
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ogy from the cloud provider Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
5021d35
to
3497496
Compare
Revert commits squashed |
/lgtm |
This was referenced Nov 8, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/cloudprovider
area/e2e-test-framework
Issues or PRs related to refactoring the kubernetes e2e test framework
area/kubelet
area/test
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/api-change
Categorizes issue or PR as related to adding, removing, or otherwise changing an API
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/apps
Categorizes an issue or PR as relevant to SIG Apps.
sig/auth
Categorizes an issue or PR as relevant to SIG Auth.
sig/cloud-provider
Categorizes an issue or PR as relevant to SIG Cloud Provider.
sig/network
Categorizes an issue or PR as relevant to SIG Network.
sig/node
Categorizes an issue or PR as relevant to SIG Node.
sig/scheduling
Categorizes an issue or PR as relevant to SIG Scheduling.
sig/storage
Categorizes an issue or PR as relevant to SIG Storage.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Updates the following labels:
These are widely used labels and although there's a bit of work involved in renaming them, we should update the label names to reflect general availability of these labels. This PR updates settings of the zone/region labels to apply both the beta and GA labels. We will be supporting both labels for the next few releases and eventually phase out the use of beta labels entirely in favor of the GA ones.
Concretely this PR:
Which issue(s) this PR fixes:
KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/20190215-promoting-cloud-provider-labels.md
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: