Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate Volume Expansion to Beta + e2e tests #81467

Merged
merged 2 commits into from Aug 28, 2019
Merged

Graduate Volume Expansion to Beta + e2e tests #81467

merged 2 commits into from Aug 28, 2019

Conversation

bertinatto
Copy link
Member

@bertinatto bertinatto commented Aug 15, 2019 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Move volume expansion support to beta and enable e2e tests.

Which issue(s) this PR fixes:

Fixes #81166

Move CSI volume expansion to beta.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/enhancements/issues/556

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 15, 2019
@bertinatto
Copy link
Member Author

/test pull-kubernetes-e2e-gce-csi-serial

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2019
@bertinatto
Copy link
Member Author

/test pull-kubernetes-e2e-gce-csi-serial

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2019
@bertinatto
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 19, 2019
@bertinatto
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@bertinatto bertinatto force-pushed the e2e_volume_expand branch 3 times, most recently from 6518df6 to 02b7b52 Compare August 20, 2019 15:51
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 27, 2019
@bertinatto bertinatto changed the title [WIP] e2e: run volume expand tests in CSI drivers Graduate Volume Expansion to Beta + e2e tests Aug 27, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2019
@gnufied
Copy link
Member

gnufied commented Aug 27, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 27, 2019
@gnufied gnufied mentioned this pull request Aug 27, 2019
Closed
@bertinatto
Copy link
Member Author

/retest

1 similar comment
@gnufied
Copy link
Member

gnufied commented Aug 27, 2019

/retest

@childsb
Copy link
Contributor

childsb commented Aug 27, 2019

/milestone 1.6

@k8s-ci-robot
Copy link
Contributor

@childsb: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.13, v1.14, v1.15, v1.16, v1.17, v1.18, v1.19]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@childsb
Copy link
Contributor

childsb commented Aug 27, 2019

/milestone 1.16

@k8s-ci-robot
Copy link
Contributor

@childsb: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.13, v1.14, v1.15, v1.16, v1.17, v1.18, v1.19]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@childsb
Copy link
Contributor

childsb commented Aug 27, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 27, 2019
@gnufied
Copy link
Member

gnufied commented Aug 27, 2019

The flakes look unrelated..

saad-ali
saad-ali approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, msau42, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2019
@msau42
Copy link
Member

msau42 commented Aug 28, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit dccd282 into kubernetes:master Aug 28, 2019
@bertinatto bertinatto mentioned this pull request Nov 4, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied gnufied left review comments

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali saad-ali approved these changes

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Move CSI Volume expansion feature gate to beta
6 participants
@bertinatto @msau42 @gnufied @childsb @k8s-ci-robot @saad-ali