Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes all-namespaces flag being ignored by ToBuilder() in builder_flags.go #81468

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@ashutoshgngwr
Copy link
Contributor

commented Aug 15, 2019

What type of PR is this?

/kind bug
/sig cli

What this PR does / why we need it:

ToBuilder() was ignoring --all-namespaces flag in builder_flags.go. I am not sure if it was intended but this was causing --all-namespaces flag to be ignored in kubectl wait. This PR corrects this behavior in order to address the filed issue.

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#699

kubectl: the --all-namespaces flag is now honored by `kubectl wait`
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

Welcome @ashutoshgngwr!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

Hi @ashutoshgngwr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from deads2k and pwittrock Aug 15, 2019
@eranreshef

This comment has been minimized.

Copy link

commented Aug 20, 2019

@deads2k @pwittrock is there any prediction for progressing with this?

@@ -128,7 +128,8 @@ func (o *ResourceBuilderFlags) ToBuilder(restClientGetter RESTClientGetter, reso
namespace, enforceNamespace, namespaceErr := restClientGetter.ToRawKubeConfigLoader().Namespace()

builder := resource.NewBuilder(restClientGetter).
NamespaceParam(namespace).DefaultNamespace()
NamespaceParam(namespace).DefaultNamespace().
AllNamespaces(*o.AllNamespaces)

This comment has been minimized.

Copy link
@deads2k

deads2k Aug 29, 2019

Contributor

It's been a while, but when I first wrote this, I recall making it possible to disable options by nil-ing out the parameters.

This comment has been minimized.

Copy link
@deads2k

deads2k Aug 29, 2019

Contributor

It's been a while, but when I first wrote this, I recall making it possible to disable options by nil-ing out the parameters.

yeah, have a look a few lines down and you can see how these are gated.

@ashutoshgngwr ashutoshgngwr force-pushed the ashutoshgngwr:fix/issue-kubectl-699 branch from dd463e8 to 535e6c0 Aug 29, 2019
…lder_flags.go
@deads2k

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

/lgtm
/ok-to-test

Copy link
Contributor

left a comment

/approve
/sig cli

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashutoshgngwr, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/priority important-soon
/milestone v1.16

@k8s-ci-robot k8s-ci-robot merged commit e102d57 into kubernetes:master Aug 29, 2019
24 checks passed
24 checks passed
cla/linuxfoundation ashutoshgngwr authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.