Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ConversionReview v1 #81476

Merged
merged 1 commit into from Aug 17, 2019

Conversation

@liggitt
Copy link
Member

commented Aug 15, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds support for ConversionReview v1 requests to conversion webhooks.

Does this PR introduce a user-facing change?:

Conversion webhooks can now indicate they support receiving and responding with `ConversionReview` API objects in the `apiextensions.k8s.io/v1` version by including `v1` in the `conversionReviewVersions` list in their CustomResourceDefinition. Conversion webhooks must respond with a ConversionReview object in the same apiVersion they receive. `apiextensions.k8s.io/v1` `ConversionReview` responses must specify a `response.uid` that matches the `request.uid` of the object they were sent.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190425-crd-conversion-webhook.md

/cc @jpbetz @smarterclayton
/sig api-machinery
/area custom-resources
/kind feature
/priority important-soon
/milestone v1.16

@k8s-ci-robot k8s-ci-robot requested review from jpbetz and smarterclayton Aug 15, 2019

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 15, 2019

@liggitt liggitt force-pushed the liggitt:conversionreview-v1 branch from 878a23b to 275c2f9 Aug 15, 2019

@liggitt liggitt added this to Required for GA, in progress in Custom Resource Definitions Aug 15, 2019

@liggitt liggitt removed the request for review from smarterclayton Aug 15, 2019

@liggitt liggitt force-pushed the liggitt:conversionreview-v1 branch from 275c2f9 to 777dff1 Aug 16, 2019

@liggitt liggitt changed the title WIP - Add support for ConversionReview v1 Add support for ConversionReview v1 Aug 16, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

last commit is ready for review

/hold
until CRD v1 PR is merged

@jpbetz

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 16, 2019

@liggitt liggitt force-pushed the liggitt:conversionreview-v1 branch from 777dff1 to 5302ef4 Aug 16, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 16, 2019

@jpbetz

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 16, 2019

@liggitt liggitt force-pushed the liggitt:conversionreview-v1 branch from 5302ef4 to ce769a5 Aug 17, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/XL and removed lgtm size/XXL labels Aug 17, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

rebased on master after #79604 merged

/hold cancel

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 17, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot merged commit 770303e into kubernetes:master Aug 17, 2019

23 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions Aug 17, 2019

@liggitt liggitt deleted the liggitt:conversionreview-v1 branch Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.