Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go to 1.12.9 #81489

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@BenTheElder
Copy link
Member

commented Aug 16, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: updates go to 1.12.9 which includes bug fixes

Which issue(s) this PR fixes:

ref #79912

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to use go 1.12.9

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

/cc @cblecker

@cblecker

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

/priority critical-urgent
/lgtm
/approve
/woof

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

@cblecker: dog image

In response to this:

/priority critical-urgent
/lgtm
/approve
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder BenTheElder force-pushed the BenTheElder:go-1.12.9 branch from 6bbd665 to 54c6744 Aug 16, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 16, 2019
@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

corrected the rules_go URL, cross checked with the workspace spec in their release notes. 🙃

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

/sig release

@cblecker

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 16, 2019
@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

/retest
k8s.gcr.io/kube-cross:v1.12.9-1 is now live.

@warmchang

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

/test pull-kubernetes-verify

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

/retest

@warmchang

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot merged commit e283836 into kubernetes:master Aug 16, 2019
22 of 23 checks passed
22 of 23 checks passed
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation BenTheElder authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 16, 2019
@BenTheElder BenTheElder deleted the BenTheElder:go-1.12.9 branch Aug 16, 2019
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2019
#81489-upstream-release-1.15

Update release-1.15 to go 1.12.9
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2019
#79966-#81390-#81489-upstream-release-1.14

Update release-1.14 to go 1.12.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.