Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only advertise supported patch types #81515

Merged
merged 1 commit into from Aug 17, 2019

Conversation

@liggitt
Copy link
Member

commented Aug 16, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
CRs do not support strategic merge patch, so don't advertise it.

Does this PR introduce a user-facing change?:

openapi now advertises correctly supported patch types for custom resources

/area custom-resources
/sig api-machinery
/cc @roycaihw @seh

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

@liggitt: GitHub didn't allow me to request PR reviews from the following users: seh.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:
CRs do not support strategic merge patch, so don't advertise it.

Does this PR introduce a user-facing change?:

openapi now advertises correctly supported patch types for custom resources

/area custom-resources
/sig api-machinery
/cc @roycaihw @seh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roycaihw

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 16, 2019

@k8s-ci-robot k8s-ci-robot merged commit c7e997b into kubernetes:master Aug 17, 2019

23 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 17, 2019

@liggitt liggitt deleted the liggitt:cr-patch-types branch Aug 17, 2019

k8s-ci-robot added a commit that referenced this pull request Sep 11, 2019
Merge pull request #81553 from liggitt/automated-cherry-pick-of-#8151…
…5-upstream-release-1.15

Automated cherry pick of #81515: Only advertise supported patch types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.