Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate kube-apiserver metrics to stability framework #81531

Merged
merged 4 commits into from Aug 28, 2019

Conversation

@logicalhan
Copy link
Contributor

commented Aug 16, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR migrates kube-apiserver metrics to the metrics stability framework

Does this PR introduce a user-facing change?:

Kube-apiserver metrics are now marked as with the ALPHA stability level.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP - Metrics Stability Migration]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190605-metrics-stability-migration.md
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

/retest

@logicalhan logicalhan force-pushed the logicalhan:kas-migration branch 2 times, most recently from f775d35 to 9b48c88 Aug 27, 2019
pkg/ssh/ssh.go Show resolved Hide resolved
Name: "apiserver_response_sizes",
Help: "Response size distribution in bytes for each group, version, verb, resource, subresource, scope and component.",
// Use buckets ranging from 1000 bytes (1KB) to 10^9 bytes (1GB).
Buckets: prometheus.ExponentialBuckets(1000, 10.0, 7),
Buckets: prometheus.ExponentialBuckets(1000, 10.0, 7),

This comment has been minimized.

Copy link
@cheftako

cheftako Aug 27, 2019

Member

Would it make sense to abstract this so that we can have an abstraction between us and the metric system everywhere except cmd?

This comment has been minimized.

Copy link
@logicalhan

logicalhan Aug 27, 2019

Author Contributor

If we intend to move off of Prometheus, it would certainly make sense to do so. There are some other Prometheus references which we did not remove for the initial migration (ie custom Prometheus collectors).

This comment has been minimized.

Copy link
@logicalhan

logicalhan Aug 27, 2019

Author Contributor

I suppose there could be other reasons as well, but it doesn’t seem strictly necessary for the immediate task at hand.

This comment has been minimized.

Copy link
@logicalhan

logicalhan Aug 27, 2019

Author Contributor

Were you thinking otherwise?

This comment has been minimized.

Copy link
@cheftako

cheftako Aug 27, 2019

Member

It just seems we are getting close to having a better abstraction between our libraries and direct prometheus. It does not have to happen in this PR (probably should be a separate PR) but it would be nice to break the hard dependency.

This comment has been minimized.

Copy link
@logicalhan

logicalhan Aug 27, 2019

Author Contributor

Yeah I agree with the general sentiment.

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

/retest

@brancz

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 27, 2019
@lavalamp

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/approve
/hold

Please add the one comment, then this is good to go.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved and removed lgtm labels Aug 27, 2019
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

/approve
/hold

Please add the one comment, then this is good to go.

Done.

/hold cancel

@logicalhan logicalhan force-pushed the logicalhan:kas-migration branch from 1150f07 to 1700a31 Aug 27, 2019
@cheftako

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/lgtm

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

/retest

2 similar comments
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

/retest

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit f24aa47 into kubernetes:master Aug 28, 2019
24 checks passed
24 checks passed
cla/linuxfoundation logicalhan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.