Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate kubelet's metrics/probes & metrics endpoint to metrics stability framework #81534

Merged
merged 2 commits into from Aug 29, 2019

Conversation

@logicalhan
Copy link
Contributor

commented Aug 16, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR migrates kubelet's metrics & metrics/probes endpoints to the metrics stability framework

Does this PR introduce a user-facing change?:

Kubelet metrics for /metrics and /metrics/probes are now marked as with the ALPHA stability level.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP - Metrics Stability Migration]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190605-metrics-stability-migration.md
@BenTheElder

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

/uncc @kubernetes/dep-approvers
/uncc
please re-cc when this builds 😅

@k8s-ci-robot k8s-ci-robot removed the request for review from kubernetes/dep-approvers Aug 17, 2019
@logicalhan logicalhan force-pushed the logicalhan:kubelet-migration branch 3 times, most recently from 409655b to eb461bd Aug 18, 2019
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

/test pull-kubernetes-e2e-gce-csi-serial

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

/test pull-kubernetes-e2e-gce-storage-slow

@logicalhan logicalhan force-pushed the logicalhan:kubelet-migration branch from 9bcab4d to 50cd58d Aug 27, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 27, 2019
@saad-ali

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Aug 27, 2019
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

/hold

I want to rebase (#81573) into this prior to merging.

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

/retest

@brancz

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/lgtm

@logicalhan logicalhan force-pushed the logicalhan:kubelet-migration branch from 50cd58d to 05f9da7 Aug 28, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 28, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan, saad-ali, sttts, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brancz

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 28, 2019
@logicalhan logicalhan force-pushed the logicalhan:kubelet-migration branch from 05f9da7 to 6f70f78 Aug 28, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 28, 2019
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

/hold cancel
Getting a bit too close to the freeze, we may not have time to merge #81573 first.

@brancz

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 28, 2019
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit ca5babc into kubernetes:master Aug 29, 2019
24 checks passed
24 checks passed
cla/linuxfoundation logicalhan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.