Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go 1.11.13 #81542

Merged
merged 3 commits into from Aug 17, 2019

Conversation

@BenTheElder
Copy link
Member

commented Aug 17, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to use go 1.11.13

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

/cc @cblecker
I'm working on the kube-cross image now.
/sig release
since this patches CVEs:
/priority critical-urgent

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

(those jobs failed due to the kube-cross image not being up yet, it's rolling out currently)

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

looks like bazel worked fine but failed on that malformed port in the vsphere/vclib test fixed in f713ec8

Fix malformed port in vsphere cloud provider test
The port name previously didn't matter on these tests, but is now
actively being checked in go1.12.8 and higher.

golang/go@3226f2d
@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

picked in f713ec8, k8s.gcr.io/kube-cross:v1.11.13-1 is now live so hopefully tests should pass this time ...

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

@cblecker

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

/lgtm
/approve

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

/lgtm
/approve

@dougm
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, dougm, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 52d3945 into kubernetes:release-1.13 Aug 17, 2019

22 of 23 checks passed

tide Not mergeable.
Details
cla/linuxfoundation BenTheElder authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Skipped.
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.

@BenTheElder BenTheElder deleted the BenTheElder:go1113 branch Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.