Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate scheduler metrics to stability framework #81576

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@logicalhan
Copy link
Contributor

commented Aug 19, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR migrates scheduler metrics to the metrics stability framework

Does this PR introduce a user-facing change?:

Scheduler metrics are now marked as with the ALPHA stability level.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP - Metrics Stability Migration]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190605-metrics-stability-migration.md
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

@k8s-ci-robot k8s-ci-robot removed request for kubernetes/dep-approvers, dixudx and ahg-g Aug 19, 2019
@logicalhan logicalhan force-pushed the logicalhan:scheduler-migration branch 2 times, most recently from 2c9c852 to bb5ce49 Aug 19, 2019
@k8s-ci-robot k8s-ci-robot added size/L and removed size/XXL labels Aug 23, 2019
@logicalhan logicalhan force-pushed the logicalhan:scheduler-migration branch 2 times, most recently from 30b3deb to f2365c7 Aug 23, 2019
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

/assign @msau42 @dims @sttts

@logicalhan logicalhan changed the title [WIP] migrate scheduler metrics to stability framework migrate scheduler metrics to stability framework Aug 23, 2019
@logicalhan logicalhan marked this pull request as ready for review Aug 23, 2019
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

/assign @brancz

@brancz

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 27, 2019
@msau42

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/approve

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

/assign @wojtek-t

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/lgtm
/approve

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 28, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@logicalhan logicalhan force-pushed the logicalhan:scheduler-migration branch from f2365c7 to 8da448d Aug 28, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 28, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan, msau42, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brancz

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit a927ed4 into kubernetes:master Aug 28, 2019
24 checks passed
24 checks passed
cla/linuxfoundation logicalhan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.