Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate controller-manager metrics to stability framework #81624

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@logicalhan
Copy link
Contributor

commented Aug 19, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR migrates controller-manager metrics to the metrics stability framework. This includes kube-controller-manager as well as cloud-controller-manager.

Does this PR introduce a user-facing change?:

Kube-controller-manager and cloud-controller-manager metrics are now marked as with the ALPHA stability level.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP - Metrics Stability Migration]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190605-metrics-stability-migration.md
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

/retest

1 similar comment
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

/retest

@logicalhan logicalhan force-pushed the logicalhan:cm-migration branch from d52777c to 64e2619 Aug 20, 2019
@brancz

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 28, 2019
@brancz

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 28, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@logicalhan logicalhan force-pushed the logicalhan:cm-migration branch from 1f50bc4 to 0241c6b Aug 28, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 28, 2019
@logicalhan logicalhan force-pushed the logicalhan:cm-migration branch from 0241c6b to 227cd3e Aug 28, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, brancz, cheftako, lavalamp, logicalhan, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logicalhan logicalhan force-pushed the logicalhan:cm-migration branch from 227cd3e to 1b6bf98 Aug 28, 2019
@brancz

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 28, 2019
@logicalhan logicalhan force-pushed the logicalhan:cm-migration branch from 1b6bf98 to 59db3ac Aug 28, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 28, 2019
@brancz

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 28, 2019
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

/retest

4 similar comments
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

/retest

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

/retest

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

/retest

@brancz

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

@logicalhan: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross 1c652fd link /test pull-kubernetes-cross
pull-publishing-bot-validate 1c652fd link /test pull-publishing-bot-validate
pull-kubernetes-local-e2e 59db3ac link /test pull-kubernetes-local-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/test pull-kubernetes-dependencies

@k8s-ci-robot k8s-ci-robot merged commit d6bc4eb into kubernetes:master Aug 29, 2019
23 of 24 checks passed
23 of 24 checks passed
pull-kubernetes-local-e2e Job failed.
Details
cla/linuxfoundation logicalhan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.