Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave Windows Defender enabled for clusters on GCE #81625

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@pjh
Copy link
Contributor

commented Aug 19, 2019

/kind cleanup

This PR stops disabling Windows Defender on nodes in clusters running on GCE. We had to disable Defender due to a Windows kernel issue (#75148) which we believe has been fixed in our Windows image from July.

Fixes #75148

Windows nodes on GCE now run with Windows Defender enabled.
@pjh

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

/cc yujuhong

@k8s-ci-robot k8s-ci-robot requested a review from yujuhong Aug 19, 2019
@pjh

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

/sig windows

@yujuhong

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

/lgtm
/approve

@yujuhong

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjh, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pjh

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5e64941 into kubernetes:master Aug 20, 2019
23 checks passed
23 checks passed
cla/linuxfoundation pjh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 20, 2019
@PatrickLang PatrickLang added this to Done (v1.16) in SIG-Windows Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.