fixes a bug that connection refused error cannot be recognized correctly #81634
Conversation
k8s-ci-robot
added
release-note
|
Hi @likakuli. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/assign @lavalamp |
|
/assign @yliaog |
|
/assign @liggitt |
|
suggested an alternative way to improve how robust this method is to changes in the network library. you can force push test/implementation changes to this branch without needing to open a new PR |
OK, thank you for your suggestion. I will try it now |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, likakuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
|
/uncc |
|
/uncc @mfojtik |
|
/retest |
| if urlErr, ok := err.(*url.Error); ok { | ||
| err = urlErr.Err | ||
| } | ||
| if opErr, ok := err.(*net.OpError); ok { |
There was a problem hiding this comment.
If ok is false for any if statement, we can return, right ?
There was a problem hiding this comment.
no, you could get a net.OpError that is not wrapped by url.Error etc..
| @@ -54,3 +54,20 @@ func IsConnectionReset(err error) bool { | |||
| } | |||
| return false | |||
| } | |||
|
|
|||
| // Returns if the given err is "connection refused" error | |||
| func IsConnectionRefused(err error) bool { | |||
There was a problem hiding this comment.
Here is another way of doing it: https://github.com/openshift/openshift-azure/blob/master/pkg/util/errors/errors.go
(not saying you have to do it that way... just fyi)
What type of PR is this?
/kind bug
What this PR does / why we need it:
When listerWatcher returns a "connection refused" error, the opError.Err's type is os.SyscallError and its Error() is "connect: connection refused". So the code
will not be excuted forever. Thus
will be excuted and the func will return.
Which issue(s) this PR fixes:
Fixes #
When there is a "connection refused" error, the reflector's ListAndWatch func will return directly but what expected is that sleep 1 second and rewatch since the specified resourceVersion.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: