Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verb to sig-node reviewers #81658

Open
wants to merge 1 commit into
base: master
from
Open

Add verb to sig-node reviewers #81658

wants to merge 1 commit into from

Conversation

@verb
Copy link
Contributor

verb commented Aug 20, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it: Add @verb to OWNERS for first-level sig-node reviews and sig-node-api-reviewers for api reviewer training.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot requested review from smarterclayton and thockin Aug 20, 2019
@verb verb force-pushed the verb:verb-reviewer branch from d755cbe to 325208f Aug 20, 2019
@verb verb changed the title Add @verb to sig-node reviewers Add verb to sig-node reviewers Aug 20, 2019
@verb

This comment has been minimized.

Copy link
Contributor Author

verb commented Aug 20, 2019

/assign @yujuhong

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Aug 30, 2019

/lgtm
/assign @dchen1107

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Sep 24, 2019

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node and removed needs-sig labels Sep 24, 2019
@verb

This comment has been minimized.

Copy link
Contributor Author

verb commented Sep 26, 2019

/retest

@verb verb force-pushed the verb:verb-reviewer branch from 325208f to 1795b45 Nov 22, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 22, 2019

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 22, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 22, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: verb
To complete the pull request process, please assign dchen1107
You can assign the PR to them by writing /assign @dchen1107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.