Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a static check failure in controller-manager #81667

Merged

Conversation

@mnogu
Copy link
Contributor

commented Aug 20, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix a static check failure in controller-manager

cmd/controller-manager/app/serve.go:65:25: prometheus.Handler is deprecated: Please note the issues described in the doc comment of InstrumentHandler. You might want to consider using promhttp.Handler instead.  (SA1019)

Which issue(s) this PR fixes:

Ref: #81657

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Welcome @mnogu!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Hi @mnogu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from lavalamp and sttts Aug 20, 2019
@mnogu mnogu force-pushed the mnogu:fix-static-check-in-controller-manager branch from 0b2f110 to 6468343 Aug 20, 2019
@ping035627

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

/ok-to-test

@mnogu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

/remove-kind bug

@k8s-ci-robot k8s-ci-robot removed the kind/bug label Aug 22, 2019
@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

/assign @cheftako

Copy link
Member

left a comment

/approve
for hack

@mnogu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

ping @cheftako for approval

@cheftako

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

Please take a look at #81624.
Seems like this may obviate you changes.

@mnogu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

Please take a look at #81624.
Seems like this may obviate you changes.

After merging #81624, I got this message:

cmd/controller-manager/app/serve.go:66:25: legacyregistry.Handler is deprecated: Please note the issues described in the doc comment of InstrumentHandler. You might want to consider using promhttp.Handler instead.  (SA1019)

How about adding a line-based linter directive to cmd/controller-manager/app/serve.go like this?

        //lint:ignore SA1019 See the Metrics Stability Migration KEP
        mux.Handle("/metrics", legacyregistry.Handler())
@mnogu mnogu force-pushed the mnogu:fix-static-check-in-controller-manager branch from 6468343 to 9f19665 Aug 31, 2019
@mnogu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

/retest

@cheftako

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 3, 2019
@cheftako

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Ping me when 1.17 opens and I'll approve.

@mnogu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

Ping me when 1.17 opens and I'll approve.

@cheftako ping

The master branch is open for pull requests for 1.17.

@cheftako

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, mnogu, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheftako

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 99c4f13 into kubernetes:master Sep 12, 2019
25 checks passed
25 checks passed
cla/linuxfoundation mnogu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.