New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ephemeral containers to streamLocation name suggestions #81678
Conversation
/retest |
/sig node |
/assign @tedyu |
/lgtm |
/assign @wojtek-t |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
/retest |
1 similar comment
/retest |
/retest |
almost there. /retest |
@wojtek-t Are you available to approve this? |
@verb Sorry - I missed that. /approve Please rebase and I will lgtm. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: verb, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This combines container names into a single list because separating them into a long, variable length string isn't particularly useful in the context of an streaming error message.
@wojtek-t rebased, thanks! |
/lgtm |
/retest |
1 similar comment
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
This combines container names into a single list because separating them into a long, variable length string isn't particularly useful in the context of a streaming error message. Continuing to conditionally append separate lists of strings would lead to the following potential error messages:
These long error messages with embedded lists make it hard to find container names at a glance, and the variable ordering makes it easy to mistake the container types. This isn't overly important since the container types aren't important in the context of someone who needs to type a container name in
kubectl
, but if the type is unimportant then we shouldn't display it in the first place.The replacement error message proposed here displays all container names a single, consistently located list that is easy to find at a glance:
What type of PR is this?
/kind cleanup
What this PR does / why we need it: Ephemeral containers are available as a streaming location.
Which issue(s) this PR fixes:
WIP #27140
Special notes for your reviewer: I expect removing container type from this error message will be controversial, and I'm not married to it, but this is how I think it should be solved so let's start there.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: