Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote the remainingItemCount field to beta #81682

Merged

Conversation

@caesarxuchao
Copy link
Member

commented Aug 20, 2019

/kind api-change

Special notes for your reviewer:

The alpha feature gate was introduced in #78553.

/sig api-machinery
/assign @smarterclayton @lavalamp

The RemainingItemCount feature is now beta.

remainingItemCount is the number of subsequent items in the list which are not included in this list response. If the list request contained label or field selectors, then the number of remaining items is unknown and the field will be left unset and omitted during serialization. If the list is complete (either because it is not chunking or because this is the last chunk), then there are no more remaining items and this field will be left unset and omitted during serialization. Servers older than v1.15 do not set this field. The intended use of the remainingItemCount is *estimating* the size of a collection. Clients should not rely on the remainingItemCount to be set or to be exact.
@dims

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from dims Aug 20, 2019
@fejta-bot

This comment has been minimized.

Copy link

commented Aug 20, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

API change approved, if you can't get a reviewer I can make some time later in the week.

/approve

@caesarxuchao caesarxuchao force-pushed the caesarxuchao:beta-remainingItemCount branch from 870b231 to 5ff5910 Aug 21, 2019
@caesarxuchao caesarxuchao force-pushed the caesarxuchao:beta-remainingItemCount branch from 5ff5910 to f9f0132 Aug 21, 2019
@k8s-ci-robot k8s-ci-robot removed the size/S label Aug 21, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caesarxuchao

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

/retest

@yliaog

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 36e0ea6 into kubernetes:master Aug 27, 2019
24 checks passed
24 checks passed
cla/linuxfoundation caesarxuchao authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.