Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: azure disk name matching issue #81720

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@andyzhangx
Copy link
Member

commented Aug 21, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
disk name matching should be case insensitive, proceeding fix with #81266

Which issue(s) this PR fixes:

Fixes #81079

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix azure disk naming matching issue due to case sensitive comparison

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

/kind bug
/assign @feiskyer
/priority important-soon
/sig cloud-provider
/area provider/azure

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

/test pull-kubernetes-bazel-test

@justaugustus

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 34450e9 into kubernetes:master Aug 23, 2019
23 checks passed
23 checks passed
cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 23, 2019
@feiskyer

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

@andyzhangx do we need cherrypicking this to old releases?

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

@andyzhangx do we need cherrypicking this to old releases?

I think so, let me do it soon.

k8s-ci-robot added a commit that referenced this pull request Aug 30, 2019
…1720-upstream-release-1.13

Automated cherry pick of #81720: fix: azure disk name matching issue
k8s-ci-robot added a commit that referenced this pull request Aug 30, 2019
…1720-upstream-release-1.15

Automated cherry pick of #81720: fix: azure disk name matching issue
k8s-ci-robot added a commit that referenced this pull request Aug 30, 2019
…1720-upstream-release-1.14

Automated cherry pick of #81720: fix: azure disk name matching issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.