Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the ipvs checks from the preflight checks #81791

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@yastij
Copy link
Member

commented Aug 22, 2019

Signed-off-by: Yassine TIJANI ytijani@vmware.com

What type of PR is this?

/sig cluster-lifecycle
/kind cleanup
/priority important-soon

What this PR does / why we need it: removes the ipvs checks from kubeadm prelight checks

Which issue(s) this PR fixes: part of kubernetes/kubeadm#1600

Special notes for your reviewer:

/assign @neolit123 @rosti

Does this PR introduce a user-facing change?:

kubeadm no longer performs IPVS checks as part of its preflight checks

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

thanks @yastij
added a couple of comments.

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
@yastij yastij force-pushed the yastij:remove-ipvs-checks branch from b928b08 to 05326f8 Aug 22, 2019
@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

btw maybe we should wait before #81752 merges as probably the import-restrictions file for kubeadm will conflict and that is a much bigger PR.

@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

/hold

@yastij

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

/retest

@rosti
rosti approved these changes Aug 23, 2019
Copy link
Member

left a comment

Thanks @yastij !
/lgtm

@neolit123 I doubt, that the import boss PR is going to merge any time soon. Let's see what happens over the weekend and merge this in the beginning of next week.

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 23, 2019
@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

/hold cancel
/lgtm

the related PR merged without .import-restriction changes in cmd/kubeadm.

@k8s-ci-robot k8s-ci-robot merged commit 90cf189 into kubernetes:master Aug 27, 2019
23 checks passed
23 checks passed
cla/linuxfoundation yastij authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 27, 2019
@yastij yastij deleted the yastij:remove-ipvs-checks branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.