Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Added OWNERS file for Topology Manager #81793
Hi @lmdaly. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
On Fri, Aug 23, 2019 at 02:51:21PM -0700, Connor Doyle wrote: ConnorDoyle commented on this pull request. > @@ -0,0 +1,7 @@ +# See the OWNERS docs at https://go.k8s.io/owners + +approvers: IIUC approvals are hierarchical, so any kubelet owner or kubelet/cm owner can also approve topology manager change. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #81793 (comment)
Hmmm, I thought that an OWNERS file applied to directories below, only if those directories didn't have an OWNERS file (i.e. I dont _think_ the files are merged). However, it's very possible I'm wrong haha :) Let's get confirmation before merging? Sounds like we're in agreement that a kubelet owner should be able to merge changes here?
Here's the snippet from https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md:
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
1 similar comment