Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OWNERS file for Topology Manager #81793

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@lmdaly
Copy link
Contributor

commented Aug 22, 2019

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Adds OWNERS file for Topology Manager

Does this PR introduce a user-facing change?:
NONE

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

@lmdaly: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

Hi @lmdaly. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lmdaly

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

@klueska

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

/ok-to-test

Copy link
Contributor

left a comment

Just a high level thought from me, but feel free to ignore if its not pertinent.

@@ -0,0 +1,7 @@
# See the OWNERS docs at https://go.k8s.io/owners

approvers:

This comment has been minimized.

Copy link
@mattjmcnaughton

mattjmcnaughton Aug 23, 2019

Contributor

Do we also want sig-node approvers to be approvers here? Only 4 people in the approvers group strikes me as slightly small... especially in the 1-2 yr future when maybe this isn't being actively worked on, engs have left companies, etc...

This comment has been minimized.

Copy link
@ConnorDoyle

ConnorDoyle Aug 23, 2019

Member

IIUC approvals are hierarchical, so any kubelet owner or kubelet/cm owner can also approve topology manager change.

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2019

@lmdaly lmdaly force-pushed the lmdaly:topology-manager-owners branch from 990b13f to 694ccbc Aug 26, 2019
@lmdaly

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

@ConnorDoyle @mattjmcnaughton The OWNERS files are inherited unless the options._no_parent_owners: true is set.

Here's the snippet from https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md:

  • options: a map of options for how to interpret this OWNERS file, currently only one:
    • no_parent_owners: defaults to false if not present; if true, exclude parent OWNERS files.
      Allows the use case where a/deep/nested/OWNERS file prevents a/OWNERS file from having > any effect on a/deep/nested/bit/of/code

Also added @derekwaynecarr to the file, just waiting @nolancon's memeber request to go through,

@dims

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

weird to see unrelated staticcheck failure:

Errors from staticcheck:
vendor/k8s.io/apiserver/pkg/admission/configuration/configuration_manager.go:80:6: func newPoller is unused (U1000)
@dims

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

@lmdaly can you please rebase to latest master and let's see if it happens again?

@lmdaly lmdaly force-pushed the lmdaly:topology-manager-owners branch from 694ccbc to 5171867 Aug 28, 2019
@lmdaly

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

@lmdaly can you please rebase to latest master and let's see if it happens again?

@dims Rebased!

@klueska

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

/retest

@klueska

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

/verify-owners

@klueska

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

/release-note-none

@lmdaly

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

/verify-owners

@lmdaly lmdaly force-pushed the lmdaly:topology-manager-owners branch from 5171867 to fbccf25 Sep 11, 2019
@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Sep 11, 2019
@lmdaly

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@ConnorDoyle

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorDoyle, lmdaly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ConnorDoyle

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

/lgtm

@klueska

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

/kind cleanup

@klueska

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

/retest

1 similar comment
@klueska

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 07cc813 into kubernetes:master Sep 12, 2019
25 checks passed
25 checks passed
cla/linuxfoundation lmdaly authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.