Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update scheduling framework interface with camelcase #81800

Conversation

@draveness
Copy link
Member

commented Aug 22, 2019

/kind cleanup
/sig scheduling
/priority important-soon
/assign @bsalamat @ahg-g @Huang-Wei

What this PR does / why we need it:

Currently, the scheduler config API uses camelcase for PreFilter, PostFilter, PreBind and PostBind plugins.

type Plugins struct {
	// PreFilter is a list of plugins that should be invoked at "PreFilter" extension point of the scheduling framework.
	PreFilter *PluginSet

	// PostFilter is a list of plugins that are invoked after filtering out infeasible nodes.
	PostFilter *PluginSet

	// PreBind is a list of plugins that should be invoked before a pod is bound.
	PreBind *PluginSet

	// PostBind is a list of plugins that should be invoked after a pod is successfully bound.
	PostBind *PluginSet
}

But in the scheduling framework API, we use the PostFilter (with capitalize F), Prefilter, Prebind and Postbind as the interface, we should make it consistent with the scheduler config API that we already agreed on and listed in the KEP.

This PR updates the following APIs in the scheduling framework:

  • Prebind -> PreBind
  • Postbind -> PostBind
  • Prefilter -> PreFilter

It would be great if we make the change before 1.16 code freeze.

Does this PR introduce a user-facing change?:

Use PostFilter instead of Postfilter in the scheduling framework
Use PreFilter instead of Prefilter in the scheduling framework
Use PreBind instead of Prebind in the scheduling framework

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@ahg-g

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

/test pull-kubernetes-bazel-test

@ahg-g

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 22, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, draveness

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3ede020 into kubernetes:master Aug 23, 2019

23 checks passed

cla/linuxfoundation draveness authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 23, 2019

@draveness draveness deleted the draveness:feature/update-post-filter-plugin-name branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.