Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: make kubeadm set defaults to kubelet configuration only when no values are set. #81903
What type of PR is this?
What this PR does / why we need it:
Currently, kubeadm set default values to several kubelet configurations which will overwrite the values set by users. Take
So, it would be better to set defaults only when the config item is not set (nil or ""), and should not change users' settings, otherwise, it may break users' expectation.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Hi @jfbai. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
also please have a look at the ticket kubernetes/kubeadm#1378
@neolit123 Thanks a lot, I will take a look at the tracked issue and update the PR as you recommended.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing