Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server side apply beta #81956

Merged
merged 3 commits into from Aug 30, 2019

Conversation

@apelisse
Copy link
Member

commented Aug 26, 2019

Enabled server-side apply as beta, rename kubectl flags to not be experimental, improve error message on conflicts to help people know what they can do.

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Server-side apply is now Beta.
@apelisse

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

This should probably not merge before #78738

@lavalamp

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Given that we're only tracking this for objects that have had an apply operation, I am planning on approving this even without waiting on:

  • #81816 (cap the number of updates to 10)
  • #77354 (use the CRD schema if available)

The critical pieces (#81754, #78738) as discussed here are already merged.

@lavalamp

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Please add a release note.

@apelisse apelisse force-pushed the apelisse:server-side-apply-beta branch from 7a32fec to f352ec4 Aug 28, 2019
@apelisse apelisse force-pushed the apelisse:server-side-apply-beta branch from f352ec4 to 1d2a81e Aug 28, 2019
@apelisse

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

No idea why the bazel test failed, that doesn't look like a flake since bazel typically re-runs test, but at the same time I don't know how I could have broken a kubelet test?

@lavalamp

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/approve

I'll just put this on now, it looks like the test flakiness will give folks ample time to object.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Adds apply-patch content-type to openapi
@apelisse apelisse force-pushed the apelisse:server-side-apply-beta branch from 1d2a81e to 3969751 Aug 28, 2019
@apelisse

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

I think this is ready.

@lavalamp

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/lgtm
/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 29, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 991d71e into kubernetes:master Aug 30, 2019
24 checks passed
24 checks passed
cla/linuxfoundation apelisse authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.