Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the CRD feature gates to GA #81965

Merged
merged 3 commits into from Aug 28, 2019

Conversation

@roycaihw
Copy link
Member

commented Aug 26, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Promote the following CRD feature gates to GA and lock the default values:

  • CustomResourceValidation
  • CustomResourceSubresources
  • CustomResourceWebhookConversion
  • CustomResourcePublishOpenAPI

Does this PR introduce a user-facing change?:

The `CustomResourceValidation`, `CustomResourceSubresources`, `CustomResourceWebhookConversion` and `CustomResourcePublishOpenAPI` features are now GA, and the associated feature gates deprecated and will be removed in v1.18.

/sig api-machinery
/area custom-resources
/priority important-soon
/cc @liggitt @sttts

roycaihw added 3 commits Aug 26, 2019
please review with whitespace change ignored (-w)
@roycaihw roycaihw force-pushed the roycaihw:crd-feature-gates-to-ga branch from aef9753 to 1878ded Aug 27, 2019
@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added this to the v1.16 milestone Aug 27, 2019
@liggitt liggitt added this to Required for GA, in progress in Custom Resource Definitions Aug 27, 2019
pull bot pushed a commit to mark0725/kubernetes that referenced this pull request Aug 28, 2019
…o-ga

Bump the CRD feature gates to GA
@k8s-ci-robot k8s-ci-robot merged commit 1878ded into kubernetes:master Aug 28, 2019
24 checks passed
24 checks passed
cla/linuxfoundation roycaihw authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.