Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cAdvisor godeps to v0.34.0 release #81972

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@dashpole
Copy link
Contributor

commented Aug 26, 2019

What type of PR is this?
/kind bug
Since this version bump contains at least one bugfix.

What this PR does / why we need it:
cAdvisor cuts a release for each kubernetes release. This is the cAdvisor release update for kubernetes 1.16.

Which issue(s) this PR fixes:
Fixes #81228

Does this PR introduce a user-facing change?:

- Fix disk stats in LXD using ZFS storage pool
- Fix CRI-O missing network metris bug
- Add `container_sockets`, `container_threads`, and `container_threads_max` metrics

/assign @dchen1107

@dashpole

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

/priority important-soon
/sig node

@dims

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

/approve
/lgtm

/assign @liggitt @smarterclayton
(for root approval)

@dashpole

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

@liggitt as someone who had to deal with many dependency nightmares with cAdvisor, I was very impressed with how easy it was to use go modules for this dependency update.
Thanks a bunch!

@dashpole

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added this to the v1.16 milestone Aug 29, 2019
@dims

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

ugh. needs rebase @dashpole

@dashpole dashpole force-pushed the dashpole:cadvisor_34 branch from 78dc6a1 to 5420d84 Aug 30, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 30, 2019
@dashpole

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@dims rebased. Needs lgtm reapplied.

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit fe770ad into kubernetes:master Aug 30, 2019
24 checks passed
24 checks passed
cla/linuxfoundation dashpole authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.