Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ephemeral inline CSI volumes as beta #82004

Merged
merged 2 commits into from Aug 29, 2019

Conversation

@pohly
Copy link
Contributor

commented Aug 27, 2019

What type of PR is this?
/kind api-change

What this PR does / why we need it:

SIG-Storage wants to move this feature to beta in Kubernetes 1.16 to make it more widely available.

Which issue(s) this PR fixes:

Related-to: kubernetes/enhancements#596

Special notes for your reviewer:

Depends on #82012 (to fix a test failure) and #81960 (to increase test coverage).

Does this PR introduce a user-facing change?:

CSI ephemeral inline volume support is beta, i.e. the CSIInlineVolume feature gate is enabled by default

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190122-csi-inline-volumes.md
- [Usage]: https://kubernetes.io/docs/concepts/storage/volumes/#csi-ephemeral-volumes
@fejta-bot

This comment has been minimized.

Copy link

commented Aug 27, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@msau42

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/assign

@pohly

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@msau42: some of the existing pkg/volumes/csi were based on the assumption that the CSIInlineVolume feature is off and now fail. Two options:

  • temporarily disable the feature at the start of those tests, similar to how it is enabled temporarily in others while the feature is in alpha
  • remove the "with/without CSIInlineVolume" distinction entirely and always assume that it is enabled

I prefer the first option myself because it gives us better overall test coverage and is less intrusive. Any thoughts?

@msau42

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Yes, first option sounds good

@pohly

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

I was waiting for #81960 to merge before updating this PR, but no luck with that so far. Perhaps tomorrow.

pohly added 2 commits Aug 27, 2019
The feature is complete and supported by an increasing number of CSI
drivers, but before it can be really used, it should be moved out of
alpha into beta.
Some tests assumed instead of ensuring that the CSIInlineVolume
feature is disabled.
@pohly pohly force-pushed the pohly:ephemeral-beta branch from 19ca34f to 482a900 Aug 28, 2019
@pohly

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

I propose that we move forward with reviewing this PR on its own. To simplify that, I removed changes that will be merged separately (#82012, #81960). Before we can merge this one, those need to be in.

Round-tripping is expected to fail and must be retested once PR #82012 is merged.

/hold

@msau42

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 28, 2019
@msau42

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/assign @smarterclayton

@msau42

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/priority important-soon

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

/retest

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

/approve
/hold cancel

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pohly

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

Thanks guys! Now we need to wait for #82012 to land in master, otherwise testing will not pass.

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 28, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot

This comment has been minimized.

Copy link

commented Aug 29, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 29, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 29, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit cd9519f into kubernetes:master Aug 29, 2019
24 checks passed
24 checks passed
cla/linuxfoundation pohly authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.