Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Framework] Add UnschedulableAndUnresolvable status code #82034

Merged

Conversation

@alculquicondor
Copy link
Member

commented Aug 27, 2019

The status can be used by (Pre)Filter plugins to indicate that preemption wouldn't change the decision of the filter.

/kind feature

What this PR does / why we need it:

It allows the scheduler to skip preemption if it wouldn't change the results of the filters.

Which issue(s) this PR fixes:

Fixes #80775

Special notes for your reviewer:

This might need a rebase if #81876 gets merged first.

Does this PR introduce a user-facing change?:

Add UnschedulableAndUnresolvable status code for Scheduler Framework

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@alculquicondor

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

/assign @wgliang

cc/ @bsalamat @ahg-g

@alculquicondor

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

/priority important-soon

Copy link
Member

left a comment

/assign @Huang-Wei @ahg-g

We may need to file an exception if we don't get it merged tomorrow.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 28, 2019
@ahg-g

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/test pull-kubernetes-integration

The status can be used by (Pre)Filter plugins to indicate that
preemption wouldn't change the decision of the filter.

Signed-off-by: Aldo Culquicondor <acondor@google.com>
@alculquicondor alculquicondor force-pushed the alculquicondor:feat/unschedulable_unresolvable branch from d70b84a to 3c1f8a8 Aug 28, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 28, 2019
@alculquicondor

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

I just removed the change in test/integration/daemonset as it was a left over from a previous approach.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 28, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

@alculquicondor: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-conformance-kind-ipv6 d70b84a link /test pull-kubernetes-conformance-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 30, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@alculquicondor

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

/milestone v1.16

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

@alculquicondor: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

@bsalamat could you handle the milestone?

@ahg-g

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

@k82cn can you apply 1.16 milestone please.

@k82cn

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit b339689 into kubernetes:master Aug 30, 2019
24 checks passed
24 checks passed
cla/linuxfoundation alculquicondor authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.