Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to TestContext to check if is IPv6 #82060

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@aojea
Copy link
Contributor

commented Aug 28, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This is a followup based on the following conversation

#81750 (comment)

to move the e2e ClusterIsIPv6() function to a method of TestContext

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This has to be merged after #82014

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@aojea

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

/hold
/assign @pohly
/assign @neolit123

@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

@aojea
PTAL at the pull-kubernetes-bazel-test failures.

having this as a member function as @pohly recommended seems better to me.
(but whether TestContext being a public variable is sane, is another topic... :))
/approve

/assign @oomichi
for /test approval.

thanks.

Copy link
Member

left a comment

This seems to make the framework clean for me.

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 28, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, neolit123, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

left a comment

/lgtm cancel

func ClusterIsIPv6() bool {
return TestContext.IPFamily == "ipv6"
}

This comment has been minimized.

Copy link
@oomichi

oomichi Aug 28, 2019

Member

Due to this change, one of unit tests related to e2elog is failed like

Ran 3 of 3 Specs in 0.022 seconds
FAIL! -- 0 Passed | 3 Failed | 0 Pending | 0 Skipped
--- FAIL: TestFailureOutput (0.04s)
    logger_test.go:104: 
        stack in 1
        Expected
            <string>: "...o:1364
            k8s...."
        to equal               |
            <string>: "...o:1369
            k8s...."
FAIL

We need to change test/e2e/framework/log/logger_test.go like

- stack: "\tutil.go:1369\nk8s.io/kubernetes/test/e2e/framework.ExpectNoError()\n\tutil.go:1363\nk8s.io/kubernetes/test/e2e/framework/log_test.glob..func1.4()\n\tlogger_test.go:49\nk8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync()\n\tlogger_test.go:65\n",
+ stack: "\tutil.go:1364\nk8s.io/kubernetes/test/e2e/framework.ExpectNoError()\n\tutil.go:1359\nk8s.io/kubernetes/test/e2e/framework/log_test.glob..func1.4()\n\tlogger_test.go:49\nk8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync()\n\tlogger_test.go:65\n",

(I faced the same problem on another PR #81685)

This comment has been minimized.

Copy link
@aojea

aojea Aug 28, 2019

Author Contributor

This has to be merged after #82014

:)

This comment has been minimized.

Copy link
@oomichi

oomichi Aug 28, 2019

Member

Ah, got it :-)

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 28, 2019
@oomichi

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 28, 2019
@aojea

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

/retest
/hold cancel

The PR that fixed the unit test failures was merged

@aojea

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

/test pull-kubernetes-conformance-kind-ipv6

@aojea

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 30, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 4ab4e20 into kubernetes:master Sep 11, 2019
24 checks passed
24 checks passed
cla/linuxfoundation aojea authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.