Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup cluster/images/conformance/go-runner test data after test done #82064

Merged

Conversation

@RainbowMango
Copy link
Member

commented Aug 28, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
After UT (cluster/images/conformance/go-runner) run, the test data tartest/out.tar.gz should be removed.

Reproduce:

[root@ecs-d8b6 kubernetes]# go test ./cluster/images/conformance/go-runner -run=TestTar        
ok  k8s.io/kubernetes/cluster/images/conformance/go-runner0.004s
[root@ecs-d8b6 kubernetes]# git status
# On branch master
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#cluster/images/conformance/go-runner/testdata/tartest/out.tar.gz
nothing added to commit but untracked files present (use "git add" to track)

It is the residues cluster/images/conformance/go-runner/testdata/tartest/out.tar.gz.

After cleanup, it looks like:

[root@ecs-d8b6 kubernetes]# go test ./cluster/images/conformance/go-runner -run=TestTar
ok  k8s.io/kubernetes/cluster/images/conformance/go-runner0.005s
[root@ecs-d8b6 kubernetes]# git status
# On branch pr_cleanup_testtar_testdata
nothing to commit, working directory clean

Which issue(s) this PR fixes:

Special notes for your reviewer:

NONE

[edit]: add release-note, none.

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

Hi @RainbowMango. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RainbowMango

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

/assign @neolit123

@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

thanks for the PR @RainbowMango

/cc @johnSchnake
for review as he authored the go-runner.

/approve
/hold
/ok-to-test

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

left a comment

/lgtm

@RainbowMango

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

Thanks @neolit123 and @johnSchnake for quick response.

Seems we can continue now.

/hold cancel

@RainbowMango RainbowMango referenced this pull request Aug 29, 2019
6 of 6 tasks complete
@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/priority backlog

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/hold

per release-managers discussion, holding low-priority, non-milestone-targeted PRs in order to free merge pool bandwidth for 1.16-targeted PRs

feel free to unhold once there are no lgtm+approve+green 1.16-targeted PRs remaining.

@lachie83

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

/hold cancel

@RainbowMango

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2019

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2019

@RainbowMango: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RainbowMango

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2019

@neolit123 @johnSchnake
Please help to add lgtm back.

@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

@RainbowMango we are in code freeze and this PR doesn't have a v1.16 milestone, which means it needs to wait for "code thaw" (10th of September).
i will leave it to @lachie83 and @johnSchnake to decided whether this is needed for release 1.16.

@lachie83

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

@RainbowMango please file an exception and tag @kacole2 and myself in the email if this should be considered for 1.16

@johnSchnake

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

Exceptions will be granted on the basis of risk and length of exception required.

IMO it is low priority, but all the criteria listed in the given link indicate an extension could be approved:

  • very well contained (to just a single test)
  • virtually 0 risk (just an tiny cleanup to a single test)
  • short time horizon (no extra time needed after the label is added. It is already good-to-go)

No reason to keep this out, at least one person wants this in; I don't see a reason to prohibit it.

@k8s-ci-robot k8s-ci-robot merged commit 9592869 into kubernetes:master Sep 11, 2019
24 checks passed
24 checks passed
cla/linuxfoundation RainbowMango authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.