Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Cleanup cluster/images/conformance/go-runner test data after test done #82064
What type of PR is this?
What this PR does / why we need it:
[root@ecs-d8b6 kubernetes]# go test ./cluster/images/conformance/go-runner -run=TestTar ok k8s.io/kubernetes/cluster/images/conformance/go-runner0.004s [root@ecs-d8b6 kubernetes]# git status # On branch master # Untracked files: # (use "git add <file>..." to include in what will be committed) # #cluster/images/conformance/go-runner/testdata/tartest/out.tar.gz nothing added to commit but untracked files present (use "git add" to track)
It is the residues
After cleanup, it looks like:
[root@ecs-d8b6 kubernetes]# go test ./cluster/images/conformance/go-runner -run=TestTar ok k8s.io/kubernetes/cluster/images/conformance/go-runner0.005s [root@ecs-d8b6 kubernetes]# git status # On branch pr_cleanup_testtar_testdata nothing to commit, working directory clean
Which issue(s) this PR fixes:
Special notes for your reviewer:
: add release-note, none.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Hi @RainbowMango. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
IMO it is low priority, but all the criteria listed in the given link indicate an extension could be approved:
No reason to keep this out, at least one person wants this in; I don't see a reason to prohibit it.