Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dualstack: IPVS proxier #82091

Merged
merged 2 commits into from Aug 30, 2019

Conversation

@khenidak
Copy link
Contributor

commented Aug 28, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR is a replacement for #80627 and is entirely @uablrek original work. The new PR is just a tidied up version of his original work [THANK YOU!]. This PR addresses the code review comments and is meant to fast track the merge process. The PR must be layered on top of #79386 which has the API changes needed by this PR.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Dual stack services (Phase II of IPv6DualStack feature) are enabled via the IPVS proxier. iptables proxier does not support dualstack yet. Dualstack iptables proxier is WIP and should catchup soon.

to enable, kube-proxy must be have the following flags:
--proxy-mode=ipvs 
--cluster-cidrs=<cidr>,<cidr> 

note:
The last two commits are part of this PR, the rest are part of #79386 and has been reviewed.

@lachie83

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/assign @thockin

@lachie83

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 28, 2019
@khenidak

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

)

func makeOptionsWithCIDRs(serviceCIDR string, secondaryServiceCIDR string) *ServerRunOptions {
value := serviceCIDR

This comment has been minimized.

Copy link
@aojea

aojea Aug 28, 2019

Contributor

shouldn't the value variable be created in the if blocks below?
seems that you check twice if len(secondaryServiceCIDR) > 0

Scratch this, didn't realize is a new PR rebased over the original

This comment has been minimized.

Copy link
@khenidak

khenidak Aug 28, 2019

Author Contributor

:-) point taken though, i will address it later on.

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/test pull-kubernetes-conformance-kind-ipv6

@khenidak

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

/test pull-kubernetes-conformance-kind-ipv6

this test has been failing for a week now, i think somebody said it is broken?

@lachie83

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

/test pull-kubernetes-conformance-kind-ipv6

this test has been failing for a week now, i think somebody said it is broken?

It's fixed. I confirmed with @BenTheElder

@khenidak

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

yeah and it has cleared this PR, so we are good. Thanks @BenTheElder

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

we had a fix to the DNS conformance tests on IPv6 pending for O(days) finally merge ~yesterday (?)

kind in general building against kubernetes master was briefly broken today by a kubeadm change, we've fixed kind and there's a follow-up to kuebadm in flight as well.

EDIT: it should pass now. It also should not block merges

@lachie83

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/hold cancel

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/priority important-soon

khenidak and others added 2 commits Aug 29, 2019
co-authored-by: Lars Ekman <lars.g.ekman@est.tech>
co-authored-by: Lars Ekman <lars.g.ekman@est.tech>
@khenidak khenidak force-pushed the khenidak:ipvs-dualstack branch from aa3906b to ef75723 Aug 29, 2019
@k8s-ci-robot k8s-ci-robot added size/XL and removed lgtm size/XXL labels Aug 29, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khenidak, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lachie83

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1ade4ce into kubernetes:master Aug 30, 2019
24 checks passed
24 checks passed
cla/linuxfoundation khenidak authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@uablrek

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

The KUBE-MARK-DROP must be created with

ip6tables -t nat -N KUBE-MARK-DROP

before kube-proxy is started with dual-stack. This chain should created by kubelet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.