Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduating Windows GMSA support to beta #82110

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@wk8
Copy link
Member

commented Aug 29, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Concerns from alpha-phase reviews have been addressed in
#80320
and
#82109
and early adopters have given positive feedback; so it seems there are
no blockers to graduate GMSA support to beta.

This patch also enables GMSA support by default, mainly for the sake of
making it easier for cluster admins to use, as well as for e2e tests in
nightly builds.

Does this PR introduce a user-facing change?:

Graduating Windows GMSA support from alpha to beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20181221-windows-group-managed-service-accounts-for-container-identity.md
Concerns from alpha-phase reviews have been addressed in
#80320
and
#82109
and early adopters have given positive feedback; so it seems there are
no blockers to graduate GMSA support to beta.

This patch also enables GMSA support by default, mainly for the sake of
making it easier for cluster admins to use, as well as for e2e tests in
nightly builds.

Signed-off-by: Jean Rouge <rougej+github@gmail.com>
@wk8

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

/hold
until #82109 is merged

@wk8

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

/priority important-soon
/sig windows

@ddebroy

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

@ddebroy: GitHub didn't allow me to assign the following users: brendanburns.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @michmike @PatrickLang @brendanburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michmike

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

/approve
/Lgtm

@wk8

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

/test pull-kubernetes-e2e-gce

@PatrickLang PatrickLang added this to In Progress (v1.16) in SIG-Windows Aug 29, 2019
@PatrickLang

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 29, 2019
@PatrickLang

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

/lgtm
/approve

Will remove hold in a bit once #82109 is in tide pool

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michmike, PatrickLang, wk8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PatrickLang

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

/hold cancel

@PatrickLang PatrickLang moved this from In Progress (v1.16) to In merge queue for 1.16 in SIG-Windows Aug 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 96a1558 into kubernetes:master Aug 30, 2019
24 checks passed
24 checks passed
cla/linuxfoundation wk8 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
SIG-Windows automation moved this from In merge queue for 1.16 to Done (v1.16) Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.