Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take the context as the first argument of Schedule #82119

Merged

Conversation

@wgliang
Copy link
Member

commented Aug 29, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
According to #81876 (comment)

FYI:https://golang.org/pkg/context/
The Context should be the first parameter

So we will take the context as the first argument of Schedule()

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Take the context as the first argument of Schedule.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@wgliang

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

/sig scheduling

@k8s-ci-robot k8s-ci-robot requested review from Huang-Wei and k82cn Aug 29, 2019
@wgliang wgliang force-pushed the wgliang:fixbug/fix-scheudle-function-context branch from bb0f07d to df579d0 Aug 29, 2019
@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Aug 29, 2019
@wgliang wgliang force-pushed the wgliang:fixbug/fix-scheudle-function-context branch from df579d0 to 008f4e2 Aug 29, 2019
@Huang-Wei

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

Technically yes, although this is not the real context.Context.

Prefer to incorporate this changes in #82072 where introduced the real context.Context.

cc/ @draveness

@wgliang

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

Technically yes, although this is not the real context.Context.

Prefer to incorporate this changes in #82072 where introduced the real context.Context.

cc/ @draveness

Agree with that. It looks better.

@wgliang

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

/cc @ahg-g
Any suggestions? Does this PR need to continue?

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g Sep 12, 2019
@draveness

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Any suggestions? Does this PR need to continue?

I believe this was superseded by #82072 :)

@Huang-Wei

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

@wgliang Would you mind closing this in favor of #82072?

@ahg-g

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

@wgliang Would you mind closing this in favor of #82072?

I think it is fine to have this one merged while we debate the other issue, we need to do this in all cases, whether #82072 ends up being merged or not.

@Huang-Wei

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Per offline discussion with @ahg-g, it seems we have another PR slipped in and made "PluginContext" as the first parameter. To make the API parameters consistent (Preempt() and Schedule()), I'm OK with merging this in.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, wgliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 82f5531 into kubernetes:master Sep 12, 2019
24 checks passed
24 checks passed
cla/linuxfoundation wgliang authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.