Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlattenListVisitor now continues traversal on errors and returns an aggregate error #82120

Merged
merged 2 commits into from Aug 30, 2019

Conversation

@soltysh
Copy link
Contributor

commented Aug 29, 2019

What type of PR is this?
/kind bug
/priority important-longterm
/sig cli

When running a kubectl get and a list of items needs to be flattened in the traversal, traversal is halted when we run into an error on a single item. This behaviour is inconsistent with what happens if we pass this same input in a format that doesn't involve a list being flattened. An example is detailed in the issue link where we have inconsistent behaviour between passing arguments in a yaml file vs directly on the command line.

This PR ensures consistency between these two behaviours by collecting errors and returning them as an aggregate as opposed to failing the command.

Which issue(s) this PR fixes:
Fixes #80541
Replaces #81452

Special notes for your reviewer:
/assign @damemi @mfojtik
cc @kharunsamuel1

Does this PR introduce a user-facing change?:

Make kubectl get --ignore-not-found continue processing when encountering error. 
kharunsamuel1 and others added 2 commits Aug 14, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 29, 2019
@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4cc80ba into kubernetes:master Aug 30, 2019
24 checks passed
24 checks passed
cla/linuxfoundation soltysh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@soltysh soltysh deleted the soltysh:bug1745532 branch Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.