Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
FlattenListVisitor now continues traversal on errors and returns an aggregate error #82120
What type of PR is this?
When running a kubectl get and a list of items needs to be flattened in the traversal, traversal is halted when we run into an error on a single item. This behaviour is inconsistent with what happens if we pass this same input in a format that doesn't involve a list being flattened. An example is detailed in the issue link where we have inconsistent behaviour between passing arguments in a yaml file vs directly on the command line.
This PR ensures consistency between these two behaviours by collecting errors and returning them as an aggregate as opposed to failing the command.
Does this PR introduce a user-facing change?:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: soltysh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing