Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CoreDNS version in Kubeadm to 1.6.2 #82127

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@rajansandeep
Copy link
Member

commented Aug 29, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:
Bumps to the latest version of CoreDNS (1.6.2) in kubeadm

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1745

Special notes for your reviewer:
#82093 includes the version bump of CoreDNS to 1.6.2 in the kube-up side.

Does this PR introduce a user-facing change?:

Kubeadm now includes CoreDNS version 1.6.2
    - The CoreDNS Deployment now checks readiness via the `ready` plugin.
    - The `proxy` plugin has been deprecated. The `forward` plugin is to be used instead.
    - `kubernetes` plugin removes the `resyncperiod` option.
    - The `upstream` option is deprecated and ignored if included.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@rajansandeep

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

thanks @rajansandeep i was just about to send the same PR.
/lgtm
/approve
/priority important-soon
/milestone v1.16
/assign @BenTheElder

@chrisohaver

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

Previous k8s approved version of CoreDNS was 1.3.1.
There are some feature deprecations between 1.3.1 and 1.6.2.

Should these be mentioned in the Kubernetes release notes?
Any examples in Docs that need to be updated?

@rajansandeep

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

@chrisohaver yes, I should mention those changes, maybe in the release notes here.
@neolit123 wdyt?

@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

Should these be mentioned in the Kubernetes release notes?

yes, I should mention those changes, maybe in the release notes here.

yes, please. extend the release note to clarify the update.

Any examples in Docs that need to be updated?

not on the kubeadm side, we already sent docs PRs that have 1.6.2 (upgrade plan example output).

@neolit123

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/approve
(hm..)

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/lgtm
/approve
thanks!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, neolit123, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

left a comment

Thanks

@aojea

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

/cc

@k8s-ci-robot k8s-ci-robot requested a review from aojea Aug 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 235f3ab into kubernetes:master Aug 30, 2019
24 checks passed
24 checks passed
cla/linuxfoundation rajansandeep authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.