Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a timeout for proxying discovery requests #82146

Merged
merged 5 commits into from Aug 30, 2019

Conversation

@deads2k
Copy link
Contributor

commented Aug 29, 2019

Fixes #82172
Fixes #82137

This is #82092 with chained contexts

Discovery requests are expected to quick. Right now there is no aggregator (proxy) level timeout on discovery requests. This adds a reasonable timeout for discovery requests from the kube-apiserver to the aggregated server.

@kubernetes/sig-api-machinery-misc
/kind bug
/priority important-soon
@liggitt @sttts

aggregated discovery requests can now timeout.  Aggregated apiserver *must* complete discovery calls within five seconds.  Other requests can take longer.
Use feature gate `EnableAggregatedDiscoveryTimeout=false` if you *must* remove this check, but that feature gate will be removed next release.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/lgtm

release note needs update for the feature gate

@deads2k deads2k force-pushed the deads2k:agg-discovery-timeout-2 branch from d50b5ae to c24a366 Aug 30, 2019
@deads2k deads2k added this to the v1.16 milestone Aug 30, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 30, 2019
@deads2k deads2k added the lgtm label Aug 30, 2019
@deads2k

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

simple rebase, reapplying.

const (
aggregatorComponent string = "aggregator"

aggregatedDiscoveryTimeout = 5 * time.Second

This comment has been minimized.

Copy link
@cheftako

cheftako Aug 30, 2019

Member

Any chance we might want to configure this?

Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit a7ac8d4 into kubernetes:master Aug 30, 2019
24 checks passed
24 checks passed
cla/linuxfoundation deads2k authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.