Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Update Apply conflict test to field manager test #82175

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@tedyu
Copy link
Contributor

commented Aug 30, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR moves Update Apply conflict to field manager test.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

This is continuation of #82135

Copy link
Member

left a comment

Looks very good, I left a few minor nits

@yutedz yutedz force-pushed the yutedz:fld-mgr-conflict branch from 8742a12 to 76bfeb5 Aug 30, 2019
@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@apelisse
Your comment has been addressed.

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

/test pull-kubernetes-conformance-kind-ipv6

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

/test pull-kubernetes-bazel-test

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

/test pull-kubernetes-conformance-kind-ipv6

@yutedz yutedz force-pushed the yutedz:fld-mgr-conflict branch 2 times, most recently from db143e6 to 3e3d985 Aug 30, 2019
@yutedz yutedz force-pushed the yutedz:fld-mgr-conflict branch from 3e3d985 to 9828f98 Aug 30, 2019
@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@apelisse
Your comment has been addressed

@apelisse

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

That's good, thanks
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f5ae060 into kubernetes:master Sep 11, 2019
24 checks passed
24 checks passed
cla/linuxfoundation yutedz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.