Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error out when Scheduler PreBind plugins return Unschedulable #82187

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@ahg-g
Copy link
Member

commented Aug 30, 2019

Scheduler PreBind plugins are currently allowed to return Unschedulable status, which should not according to the KEP and comments.

What type of PR is this?
/kind bug

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahg-g ahg-g force-pushed the ahg-g:ahg-prebind branch from dfce853 to 7d4bb38 Aug 30, 2019
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Aug 30, 2019
@wgliang

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

/retest
/lgtm
/kind cleanup

Copy link
Member

left a comment

This check is also not necessary.

if preBindStatus.IsUnschedulable() {

And same for permit plugins?
https://github.com/kubernetes/kubernetes/pull/80416/files#r312374563

@liggitt

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

all scheduler-related PRs in the failing batches: #82187 #82209 #82222

@ahg-g

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

all scheduler-related PRs in the failing batches: #82187 #82209 #82222

We suspect that this one is not relevant, so we will cancel the hold on this one and keep it on the other two to see if the integration test becomes green constantly.

/hold cancel

@liggitt

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

thanks for checking, see also investigation in #82209 (comment) which seemed to point to #82222

@ahg-g

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

/hold

@ahg-g ahg-g force-pushed the ahg-g:ahg-prebind branch from 7d4bb38 to 77fec82 Sep 11, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 11, 2019
@ahg-g ahg-g force-pushed the ahg-g:ahg-prebind branch from 77fec82 to ac1079c Sep 11, 2019
…le status, which should not according to the KEP and comments.
@ahg-g ahg-g force-pushed the ahg-g:ahg-prebind branch from ac1079c to 54ac023 Sep 11, 2019
@ahg-g

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

/hold cancel

@Huang-Wei

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

/lgtm

@Huang-Wei

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

/retest

@ahg-g

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@ahg-g

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

/test pull-kubernetes-e2e-gce-100-performance

@ahg-g

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

/test pull-kubernetes-node-e2e

@liggitt

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

that test job failure is pervasive - fix in kubernetes/test-infra#14291

@fejta-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 1e70457 into kubernetes:master Sep 12, 2019
25 checks passed
25 checks passed
cla/linuxfoundation ahg-g authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.