Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default etcd server to 3.3.15 for kubernetes 1.16 #82199

Merged
merged 2 commits into from Sep 5, 2019

Conversation

@dims
Copy link
Member

commented Aug 30, 2019

We already bumped etcd client to 3.3.15 before code freeze but we neglected to bump the server itself. Also see additional information in kubernetes/kubeadm#1726

Change-Id: I68f1a5e5339d83077a1a9f312c4e6e33848886c5

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Updated default etcd service used by kubernetes to 3.3.15

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@dims

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

I assume not pushed yet?

I0830 21:47:53.331] time="21:47:53" level=warning msg="Failed to pull k8s.gcr.io/etcd:3.3.15 with error: exit status 1"

Update default etcd server to 3.3.15 for kubernetes 1.16
Change-Id: I68f1a5e5339d83077a1a9f312c4e6e33848886c5

@dims dims force-pushed the dims:update-to-etcd-3.3.15-0-image branch from 4444e1d to 8fbfdf8 Aug 31, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2019

@BenTheElder correct, we need to build and push that

Fix failure running `make build test` in cluster/images/etcd
Change-Id: I5072d06402d211c17c8c5fb952e193bd1e57c07d
@dims

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2019

/assign @jpbetz @yuwenma
cc @gyuho

@dims dims changed the title [WIP] Update default etcd server to 3.3.15 for kubernetes 1.16 Update default etcd server to 3.3.15 for kubernetes 1.16 Aug 31, 2019

@neolit123

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

/test pull-kubernetes-e2e-kind
(this should fail the first run)

@dims

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-conformance-kind-ipv6

@neolit123

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

time="18:18:43" level=info msg="Failed to pull image: k8s.gcr.io/etcd:3.3.15" error="exit status 1"

@dims the image tag should be 3.3.15-0.
hopefully the revision doesn't break something.

@jpbetz

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

/retest

@dims

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-gce

@dims

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

@neolit123 Hmmmm

@neolit123

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

haven't looked at the layers. i tried docker pull gcr.io/google-containers/etcd:3.3.15-0 and it works.
docker pull gcr.io/google-containers/etcd:3.3.15 doesn't and that is the reason for the pull-kubernetes-e2e-kind failure at least.

@jpbetz

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

3.3.15 image tags published

/retest

@jpbetz

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

/lgtm
/approve

@neolit123

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

cc @liggitt
PTAL for approval of the staging/src/k8s.io/sample-apiserver/
/cluster too i guess.

@liggitt

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims, jpbetz, justaugustus, liggitt, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

thanks
/hold cancel

@dims

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

/test pull-kubernetes-node-e2e

@fejta-bot

This comment has been minimized.

Copy link

commented Sep 5, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

commented Sep 5, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@dims

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

/test pull-kubernetes-node-e2e

@dims

This comment has been minimized.

Copy link
Member Author

commented Sep 5, 2019

node-e2e is not flaky, it's missing an image - fix is here kubernetes/test-infra#14203

@liggitt

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit c4c6467 into kubernetes:master Sep 5, 2019

25 checks passed

cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
mboersma added a commit to mboersma/aks-engine that referenced this pull request Sep 10, 2019
@den-is den-is referenced this pull request Sep 11, 2019
jackfrancis added a commit to Azure/aks-engine that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.