Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golint failures of pkg/kubelet #82233

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@SataQiu
Copy link
Member

commented Sep 2, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fix golint failures of pkg/kubelet

Which issue(s) this PR fixes:

Ref #68026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@SataQiu

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

/test pull-kubernetes-bazel-build

@SataQiu

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

Copy link
Contributor

left a comment

/lgtm

For those wondering about making ReasonItem public, there's a good convo here: #78179 (previous attempt at resolving this go lint failure)

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 3, 2019
// Reason is the cached item in ReasonCache
type reasonItem struct {
// ReasonItem is the cached item in ReasonCache
type ReasonItem struct {

This comment has been minimized.

Copy link
@thockin

thockin Sep 3, 2019

Member

Why make thsi public at the same time? it can still be reasonItem

This comment has been minimized.

Copy link
@SataQiu

SataQiu Sep 4, 2019

Author Member

Thanks @thockin
Because the function Get is public, it's return value should be public also IMO.
Ref : https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/reason_cache.go#L96

We can't change Get to get, as it is called in other packages.

This comment has been minimized.

Copy link
@thockin

thockin Sep 6, 2019

Member

My point was that it's not public today and you are changing it to public. Clearly whomever is using it is OK with the type not being public. It's a little weird, sure, but it's not illegal.

That said it's pretty insignifiicant, so sure. It's less weird.

Copy link
Member

left a comment

Thanks!

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 252a7ec into kubernetes:master Sep 11, 2019
24 checks passed
24 checks passed
cla/linuxfoundation SataQiu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.