Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add identification for particular certificate controllers #82279

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@deads2k
Copy link
Contributor

commented Sep 3, 2019

fixes #82278

When certificate controllers don't start as expected, you don't get identifiable output in the logs. This adds that information.

/kind bug
/priority important-soon
@kubernetes/sig-auth-bugs

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -47,6 +47,7 @@ func NewCSRSigningController(
return nil, err
}
return certificates.NewCertificateController(
"signer",

This comment has been minimized.

Copy link
@liggitt

liggitt Sep 3, 2019

Member

should this match the name used in the controller manager (e.g. csrsigning)?

This comment has been minimized.

Copy link
@deads2k

deads2k Sep 3, 2019

Author Contributor

should this match the name used in the controller manager (e.g. csrsigning)?

That would cause certificate_controller.go:114] Starting certificate controller "csrsigning" instead of certificate_controller.go:114] Starting certificate controller "signer". I have no real preference if you do though.

@@ -49,6 +49,7 @@ func NewCSRApprovingController(client clientset.Interface, csrInformer certifica
recognizers: recognizers(),
}
return certificates.NewCertificateController(
"sar-approver",

This comment has been minimized.

Copy link
@liggitt

liggitt Sep 3, 2019

Member

should this match the name used in the controller manager (e.g. csrapproving)?

@deads2k

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

updated strings.

@deads2k deads2k force-pushed the deads2k:which-cert branch from b70a31e to e8b5781 Sep 3, 2019
@liggitt

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

/lgtm
/retest

@fejta-bot

This comment has been minimized.

Copy link

commented Sep 3, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 1146e0c into kubernetes:master Sep 11, 2019
24 checks passed
24 checks passed
cla/linuxfoundation deads2k authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.