Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixing bugs related to Endpoint Slices #82289
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Hi @robscott. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
@bowei - I believe this PR is awaiting your comments. Can you please comment at your earliest convenience as this PR potentially fixes a 1.16 release-blocking job so time is of the upmost importance as we are less than 2 weeks out from release. If we don't think we can't get this merged within the next 48 hours I need to know so we can discuss reverting the commits for the enhancement. I just wanted to let you know where we stand as part of the 1.16 release. Thanks
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing