Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dns capability to GCE window cluster #82314

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@lzang
Copy link
Contributor

commented Sep 4, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add dns capability to GCE/GKE window clusters so that dns suffix search list will be programmed for windows pods.

Which issue(s) this PR fixes:
User cannot do dns lookup without full FQDN, such as service name, from their windows pods.

Does this PR introduce a user-facing change?:
None

Fix the dns suffix search list for GCE window clusters.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Hi @lzang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from gmarek and pjh Sep 4, 2019
@lzang

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

/sig windows
/assign @yujuhong @pjh

Copy link
Contributor

left a comment

Thanks a lot for making this change!

cluster/gce/util.sh Outdated Show resolved Hide resolved
cluster/gce/windows/k8s-node-setup.psm1 Outdated Show resolved Hide resolved
cluster/gce/windows/k8s-node-setup.psm1 Outdated Show resolved Hide resolved
cluster/gce/windows/k8s-node-setup.psm1 Outdated Show resolved Hide resolved
cluster/gce/windows/k8s-node-setup.psm1 Outdated Show resolved Hide resolved
@pjh

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

/ok-to-test

@lzang lzang force-pushed the lzang:master branch 2 times, most recently from ccf6593 to 3d0acaf Sep 4, 2019
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Sep 4, 2019
@lzang lzang force-pushed the lzang:master branch 2 times, most recently from a584366 to 894dbe6 Sep 4, 2019
@pjh

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 5, 2019
@lzang lzang force-pushed the lzang:master branch from 894dbe6 to 73ce2df Sep 5, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 5, 2019
@lzang lzang force-pushed the lzang:master branch from 73ce2df to 2a3ab18 Sep 5, 2019
@pjh

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 5, 2019
@lzang

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

/retest

1 similar comment
@lzang

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

/retest

Copy link
Member

left a comment

Add a release note so we can cherry-pick?

@@ -872,7 +872,7 @@ function construct-windows-kubelet-flags {
# double-quotes, because they still break sc.exe after expansion in the
# binPath parameter, and single-quotes get parsed as characters instead of
# string delimiters.
flags+=" --resolv-conf="
flags+=" --resolv-conf=${WINDOWS_CNI_CONFIG_DIR}\hostdns.conf"

This comment has been minimized.

Copy link
@yujuhong

yujuhong Sep 5, 2019

Member

Reminder: will need to make the change in GKE separately.

@yujuhong

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

/approve
Thanks for the fix!

@yujuhong yujuhong added this to the v1.16 milestone Sep 5, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzang, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 397ed0e into kubernetes:master Sep 5, 2019
24 checks passed
24 checks passed
cla/linuxfoundation lzang authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
k8s-ci-robot added a commit that referenced this pull request Sep 20, 2019
…upstream-release-1.15

Automated cherry pick of #82314: Add dns capability to GCE window cluster
@PatrickLang PatrickLang added this to Done (v1.16) in SIG-Windows Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.