Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to schemaless apply behavior for custom resources with unhandled schemas #82438

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@liggitt
Copy link
Member

commented Sep 6, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Falls back to schema-less behavior for server-side-apply for custom resources defined with schemas that are not handled by kube-openapi.

An inability to construct the schema for server-side-apply to use should not block serving of existing CRDs

Which issue(s) this PR fixes:
Fixes #82436

Does this PR introduce a user-facing change?:

Resolved regression serving custom resources with unhandled validation schemas with the ServerSideApply feature enabled

/sig api-machinery
/cc @apelisse @jennybuckley @sttts
/milestone v1.16
/priority critical-urgent

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jennybuckley

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 6, 2019

@liggitt liggitt added this to Bugs/Cleanup/Tests in Custom Resource Definitions Sep 6, 2019

@jennybuckley jennybuckley referenced this pull request Sep 6, 2019
42 of 70 tasks complete
@liggitt

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

/retest

1 similar comment
@liggitt

This comment has been minimized.

Copy link
Member Author

commented Sep 6, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit e682310 into kubernetes:master Sep 6, 2019

24 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt moved this from Bugs/Cleanup/Tests to Complete in Custom Resource Definitions Sep 9, 2019

@liggitt liggitt deleted the liggitt:apply-fallback branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.