Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup several GA feature flags which should be removed in 1.17 #82472

Merged

Conversation

@draveness
Copy link
Member

draveness commented Sep 9, 2019

/kind cleanup
/priority backlog

What this PR does / why we need it:

Remove several GA features flag in 1.17

  • EnableAggregatedDiscoveryTimeout @deads2k
  • PersistentLocalVolumes @msau42
  • deprecatedGCERegionalPersistentDisk @verult

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The deprecated feature gates `GCERegionalPersistentDisk`, `EnableAggregatedDiscoveryTimeout` and `PersistentLocalVolumes` are now unconditionally enabled and can no longer be specified in component invocations.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot requested review from caesarxuchao and jingxu97 Sep 9, 2019
@draveness draveness changed the title feat: remove several GA feature flags in 1.17 feat: cleanup several GA feature flags which should be removed in 1.17 Sep 9, 2019
@tengqm

This comment has been minimized.

Copy link
Contributor

tengqm commented Sep 9, 2019

Thanks.

@draveness draveness force-pushed the draveness:feature/remove-feature-gates-in-1-17 branch from b5cf7af to 325bf30 Sep 9, 2019
@draveness draveness force-pushed the draveness:feature/remove-feature-gates-in-1-17 branch from 325bf30 to 14dc59e Sep 9, 2019
@deads2k

This comment has been minimized.

Copy link
Contributor

deads2k commented Sep 9, 2019

@sjenning @gnufied please confirm.

//
// Enable the aggregated discovery timeout to ensure client responsiveness. Note this feature is present
// only for backward compatibility, it will be removed in the 1.17 release.
EnableAggregatedDiscoveryTimeout featuregate.Feature = "EnableAggregatedDiscoveryTimeout"

This comment has been minimized.

Copy link
@deads2k

deads2k Sep 9, 2019

Contributor

this one lgtm

@gnufied

This comment has been minimized.

Copy link
Member

gnufied commented Sep 9, 2019

Local storage change looks good.

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Sep 9, 2019

/approve
PersistentLocalVolumes and deprecatedGCERegionalPersistentDisk feature gate removal

@draveness

This comment has been minimized.

Copy link
Member Author

draveness commented Sep 10, 2019

@deads2k please take another look since the other two feature gates removal have been approved by @msau42, thanks

@draveness

This comment has been minimized.

Copy link
Member Author

draveness commented Sep 10, 2019

/assign @deads2k

@draveness draveness requested a review from deads2k Sep 17, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

draveness commented Sep 17, 2019

/assign @liggitt

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Sep 17, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, liggitt, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3a19f1e into kubernetes:master Sep 17, 2019
24 checks passed
24 checks passed
cla/linuxfoundation draveness authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 17, 2019
@draveness draveness deleted the draveness:feature/remove-feature-gates-in-1-17 branch Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.