Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in KeyUsage constant names #82511

Merged
merged 1 commit into from Sep 27, 2019

Conversation

@abursavich
Copy link
Contributor

commented Sep 10, 2019

What type of PR is this?
/kind api-change
/kind cleanup

What this PR does / why we need it:
This fixes typos in KeyUsage constant names.

I am generating code from the API packages and this tickled an edge case where I'm trying to generate nicer enum names.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
As possible precedence for changing constant names, one of these typos was introduced by a PR attempting to fix typos: #59464

Does this PR introduce a user-facing change?:
I'm not 100% sure what constitutes a "user-facing" change... This could break users of the Go k8s.io/api/certificates/v1beta1 package.

Fix typos in `certificates.k8s.io/v1beta1` KeyUsage constant names: `UsageContentCommittment` becomes `UsageContentCommitment` and `UsageNetscapSGC` becomes `UsageNetscapeSGC`.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Hi @abursavich. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

left a comment

/ok-to-test

Thanks for the catch

@fejta-bot

This comment has been minimized.

Copy link

commented Sep 10, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@neolit123

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

I'm not 100% sure what constitutes a "user-facing" change... This could break users of the Go k8s.io/api/certificates/v1beta1 package.

changes in kubeadm or pkg/apis/certificates/types.go are OK, since these packages should not be vendored, however staging/src/k8s.io/api/certificates/v1beta1/types.go could break users.

i think the correct approach is to introduce these changes in a new certificates/v1beta2 version.

@neolit123

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

@abursavich
you can ask in the k8s slack channel #sig-auth about this.

@abursavich

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

i think the correct approach is to introduce these changes in a new certificates/v1beta2 version.

If the change would break encoding (rpc, storage, etc.), then I don't think there would be a question — v1beta2 would be required. But this change only breaks the Go package API and, rightly or wrongly, there does seem to be plenty of precedents for that.

you can ask in the k8s slack channel #sig-auth about this.

I dropped the question in the slack channel and will wait for a response... Thanks!

@deads2k

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

I'm not 100% sure what constitutes a "user-facing" change... This could break users of the Go k8s.io/api/certificates/v1beta1 package.

changes in kubeadm or pkg/apis/certificates/types.go are OK, since these packages should not be vendored, however staging/src/k8s.io/api/certificates/v1beta1/types.go could break users.

i think the correct approach is to introduce these changes in a new certificates/v1beta2 version.

We do not guarantee source compatibility between releases. This came up on the sig-arch mailing list too. Source incompatible changes like this are allowed without new packages.

@abursavich

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

I didn't try to grok all 85k lines of log output, but it seems like those test failures were unrelated and around copying test artifacts after the fact.

/retest

@abursavich abursavich requested a review from draveness Sep 11, 2019
Copy link
Member

left a comment

/lgtm

Thanks, Please update the release note with the original and replacement constants.

@draveness

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

/remove-kind api-change

@abursavich

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

Thanks, Please update the release note with the original and replacement constants.

Done, thanks.

@deads2k

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

/lgtm

@abursavich

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

/assign @smarterclayton

@abursavich

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

Gentle nudge... small change waiting 2 weeks for approval.

@neolit123

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

i can only approve the kubeadm change. the rest is on the api-approvers.
/approve

@dims

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

/assign @liggitt

@liggitt

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abursavich, liggitt, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Sep 27, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit dd5efc4 into kubernetes:master Sep 27, 2019
25 checks passed
25 checks passed
cla/linuxfoundation abursavich authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.