Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'imagetag' -> 'image' in edit set command examples #82535

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@demobox
Copy link
Contributor

commented Sep 10, 2019

'imagetag' is not/no longer supported as a command

Correct a reference to a not/no longer used kustomize subcommand in the documentation
'imagetag' is not/no longer supported as a command
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Welcome @demobox!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Hi @demobox. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@demobox

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

I signed it

@hpandeycodeit

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

@demobox Thanks for the PR! Can you edit the PR to add the Release Notes Section and the Kind of fix this PR is providing?

https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md

Also, Looks like the CLA is missing.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@demobox

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

I signed it

@pwittrock

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/lgtm

@pwittrock

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/approve

@pwittrock

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/oktotest

@seans3

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: demobox, pwittrock, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seans3

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

NONE
@seans3
seans3 approved these changes Sep 10, 2019
@seans3

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

/kind cleanup
/priority important-soon

@seans3
seans3 approved these changes Sep 10, 2019
Copy link
Contributor

left a comment

Please add a release note--thanks.

@seans3

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

/ok-to-test

@demobox

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

Can you edit the PR to add the Release Notes Section and the Kind of fix this PR is providing?

@hpandeycodeit Added - thanks for the hint!

@seans3 I see you also added NONE as the release note - was that intended as a temporary value to move the process along? Happy to update the note I added in the PR description if we feel NONE is more appropriate for this change

@fejta-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 1f2e9cf into kubernetes:master Sep 12, 2019
25 checks passed
25 checks passed
cla/linuxfoundation demobox authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.